Recreate #1740: Forward-port: Ensure mempool always closes stale forkers #1741
+61
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
amesgen,
bladyjoker,
dnadales,
fraser-iohk,
geo2a and
nfrisby
as code owners
amesgen
reviewed
Oct 29, 2025
There was a problem hiding this comment.
Approving the first commit as a port from #1738
The second commit commit also makes sense in general as per #1565 (comment), but it isn't really related to the first commit, and also, we didn't yet update to resource-registry-0.2 in this branch, right? So maybe move it to #1714?
jasagredo
force-pushed
the
js/fix-mempool-dangling-forker-forward-port
branch
from
13ee157 to
83a00de
Compare
jasagredo
force-pushed
the
js/fix-mempool-dangling-forker-forward-port
branch
from
83a00de to
2369c86
Compare
This was referenced Oct 31, 2025
amesgen
approved these changes
Oct 31, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Consensus Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.